Discussion in 'Releases' started by ice cold, Jul 23, 2017.

Approved KillFeed 1.1.5

this plugin send a popup on the Atacker his screen

  1. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    #1
  2. DreTaX
    Offline

    DreTaX Probably knows the answer... Administrator

    Joined:
    Jun 29, 2014
    Messages:
    3,927
    Likes Received:
    706
    Approved.
     
    #2
  3. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    thx
     
    #3
  4. DreTaX
    Offline

    DreTaX Probably knows the answer... Administrator

    Joined:
    Jun 29, 2014
    Messages:
    3,927
    Likes Received:
    706
    Suggestions.

    Code (Python):
    import clr
    clr.AddReferenceByPartialName("Fougerite")
    import Fougerite


    class KillNotice:
        def On_PlayerKilled(self, DeathEvent):
            # Ensure that both the killer is a player and the victim is also a player
            # This is because the killer can be "world", "npc" too, and It would cause errors.
            if DeathEvent.VictimIsPlayer and DeathEvent.AttackerIsPlayer:
                DeathEvent.Attacker.Notice("☠", "You killed " + DeathEvent.Victim.Name)
     
    #4
  5. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    I'm i allowed to upload this one as update?
     
    #5
  6. Jakkee
    Offline

    Jakkee Plugin Developer Plugin Developer Contributor

    Joined:
    Jul 28, 2014
    Messages:
    1,454
    Likes Received:
    138
    Yes, Just make sure you credit. EG: Verson Blah blah - Fix by DreTaX
     
    #6
    • Like Like x 1
  7. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    #7
    Last edited: Jul 24, 2017
  8. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    #8
  9. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    #9
  10. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    #10
  11. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    #11
  12. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    #12
  13. Mr. Bean ✅
    Offline

    Mr. Bean ✅ New Member Member

    Joined:
    Mar 3, 2017
    Messages:
    6
    Likes Received:
    1
    Every time you get killed by a wolf or bear it shows this error message.

    [1/22/2019 3:52:25 AM] [Error] [Error] Failed to invoke: KillFeed<Python>.On_PlayerKilled()
    'Entity' object has no attribute 'SteamID'
    System.Object GetError(System.Runtime.CompilerServices.CallSite, System.Object, IronPython.Runtime.CodeContext)
    at IronPython.Runtime.Binding.PythonGetMemberBinder+FastErrorGet`1[System.Object].GetError (System.Runtime.CompilerServices.CallSite site, System.Object target, IronPython.Runtime.CodeContext context) [0x00000] in <filename unknown>:0
    at System.Dynamic.UpdateDelegates.UpdateAndExecute2[Object,CodeContext,Object] (System.Runtime.CompilerServices.CallSite site, System.Object arg0, IronPython.Runtime.CodeContext arg1) [0x00000] in <filename unknown>:0
    at IronPython.Runtime.Binding.PythonGetMemberBinder+FastPropertyGet`1[System.Object].GetProperty (System.Runtime.CompilerServices.CallSite site, System.Object target, IronPython.Runtime.CodeContext context) [0x00000] in <filename unknown>:0
    at Microsoft.Scripting.Interpreter.DynamicInstruction`3[System.Object,IronPython.Runtime.CodeContext,System.Object].Run (Microsoft.Scripting.Interpreter.InterpretedFrame frame) [0x00000] in <filename unknown>:0
    at Microsoft.Scripting.Interpreter.Interpreter.Run (Microsoft.Scripting.Interpreter.InterpretedFrame frame) [0x00000] in <filename unknown>:0
    Traceback (most recent call last):
    File "<string>", line 44, in On_PlayerKilled
    AttributeError: 'Entity' object has no attribute 'SteamID'
     
    #13
    • Like Like x 1
  14. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    oh yeah ahahha i totally forgot about this bug, thanks for reporting it again ;) i wil update soon
     
    #14
  15. Watch dogs
    Offline

    Watch dogs New Member Member

    Joined:
    Nov 27, 2018
    Messages:
    19
    Likes Received:
    0
    ah that bug dam that would be very annoying each time to
     
    #15
  16. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    #16
  17. Mr. Bean ✅
    Offline

    Mr. Bean ✅ New Member Member

    Joined:
    Mar 3, 2017
    Messages:
    6
    Likes Received:
    1
    #17
  18. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    lol
     
    #18
  19. DreTaX
    Offline

    DreTaX Probably knows the answer... Administrator

    Joined:
    Jun 29, 2014
    Messages:
    3,927
    Likes Received:
    706
    Well...

    Issue:
    Code (Python):
        def On_PlayerKilled(self, DeathEvent):
            if self.Enable == 1:
                if DataStore.Get("pop", DeathEvent.Attacker.SteamID):
                    if DeathEvent.VictimIsPlayer and DeathEvent.AttackerIsPlayer:
                        DeathEvent.Attacker.Notice("☠", "You killed " + DeathEvent.Victim.Name)
    If checks are at wrong place, nullchecks should also be there.
    Code (Python):
        def On_PlayerKilled(self, DeathEvent):
            if self.Enable == 1:
                if DeathEvent.VictimIsPlayer and DeathEvent.AttackerIsPlayer and DeathEvent.Victim is not None and DeathEvent.Attacker is not None:
                    if DataStore.Get("pop", DeathEvent.Attacker.SteamID):
                        DeathEvent.Attacker.Notice("☠", "You killed " + DeathEvent.Victim.Name)
    NPCKill fix:

    Code (Python):
        def On_NPCKilled(self, DeathEvent):
            if self.NpcKill == 1:
                if DeathEvent.Attacker is not None and DataStore.Get("pop", DeathEvent.Attacker.SteamID):
                    DeathEvent.Attacker.Notice("☠", "You killed a " + DeathEvent.Victim.Name)
     
    #19
    • Like Like x 2
  20. ice cold
    Offline

    ice cold Active Member Member

    Joined:
    Oct 24, 2016
    Messages:
    610
    Likes Received:
    65
    oh thanks now i see ahhahahah
     
    #20

Share This Page