TpFriend Conversion

[DreTaX]

No time to test, but: https://github.com/dretax/Python-Plugins/tree/master/PlutonPlugins/TpFriend

Doesn't contain the delay yet. Didn't have the time for It yet.

 

[coersum]

I spent the day making my own before finding your plugin...(/tpask, /tpaccept, /tpdeny but not as bug free as yours I am sure (never thought of the names with spaces in them or that player find function worked on partial names so would have been bad!).

I tested it a bit but noticed, on /tpa playername , I get some errors on:

playertor = self.CheckV(Player, args)

after some debugging, I noticed it's because in CheckV() you use:

systemname = ini.GetSetting("Main", "Name")

but your config file is setup for:

systemname = ini.GetSetting("Settings", "sysname")

(you have Settings/sysname in all other loading of your config file).

*****************************************************************
Now farther down, you use Time which you get from DataStore, but if it has not been set yet, you get an error when you use it in:

calc = System.Environment.TickCount - time

so maybe (again new guy suggestion):

replace:

                time = DataStore.Get("tpfriendcooldown", Player.SteamID)
                usedtp = DataStore.Get("tpfriendusedtp", Player.SteamID)
                # if time is not set in DataStore, you get an error on the next line
                calc = System.Environment.TickCount - time
                if time == None or calc < 0 or math.isnan(calc):
                    time = DataStore.Add("tpfriendcooldown", Player.SteamID, System.Environment.TickCount)

with:

                usedtp = DataStore.Get("tpfriendusedtp", Player.SteamID)
                if DataStore.ContainsKey("tpfriendcooldown", Player.SteamID):
                    time = DataStore.Get("tpfriendcooldown", Player.SteamID)
                else:
                    time = DataStore.Add("tpfriendcooldown", Player.SteamID, System.Environment.TickCount)
                calc = System.Environment.TickCount - time

Hope that helps. I'm wondering if it's not my setup that is wrong somehow and giving me those errors, let me know.

 

[coersum]

And finally:

playerfromm = Server.Find(pending)

to

playerfromm = Server.FindPlayer(pending)

x2

playerfromm.SafeTeleportTo(Player.Location)

to

playerfromm.GroundTeleport(Player.Location)

or

playerfromm.Teleport(Player.Location)

Also, and I have no clue why, just test and error, changing:

from System import *

to

import System

removed some errors.. with all those modification (and from my limited tests), it works great. I haven't tested names with spaces or special character etc.

 

[DreTaX]

Please note that this didnt gp to the releases cause of that. It was a 10 mins conversion ;P

Sent from my Samsung Galaxy S4

 

[DreTaX]

And finally:

playerfromm = Server.Find(pending)

to

playerfromm = Server.FindPlayer(pending)

x2

playerfromm.SafeTeleportTo(Player.Location)

to

playerfromm.GroundTeleport(Player.Location)

or

playerfromm.Teleport(Player.Location)

Also, and I have no clue why, just test and error, changing:

from System import *

to

import System

removed some errors.. with all those modification (and from my limited tests), it works great. I haven't tested names with spaces or special character etc.

Thanks for the list thox atleast I dont have to find them myself xD

Sent from my Samsung Galaxy S4

 

[coersum]

Oh I know you didn't test it (said so in your post), I had time so I figured I'd try to help.

 

[DreTaX]

Thanks again.

Sent from my Samsung Galaxy S4

 

[DreTaX]

And finally:

playerfromm = Server.Find(pending)

to

playerfromm = Server.FindPlayer(pending)

x2

playerfromm.SafeTeleportTo(Player.Location)

to

playerfromm.GroundTeleport(Player.Location)

or

playerfromm.Teleport(Player.Location)

Also, and I have no clue why, just test and error, changing:

from System import *

to

import System

removed some errors.. with all those modification (and from my limited tests), it works great. I haven't tested names with spaces or special character etc.

Safe Teleport remained in from the conversion.

And nah. Replacing the nan check to this:

usedtp = DataStore.Get("tpfriendusedtp", Player.SteamID)
                if DataStore.ContainsKey("tpfriendcooldown", Player.SteamID):
                    time = DataStore.Get("tpfriendcooldown", Player.SteamID)

can break the plugin. Any value can be contained in the ds if you give that, even NAN. But you cannot calculate with nan. That solution is wrong.


This can be a solution:

systick = System.Environment.TickCount
                usedtp = DataStore.Get("tpfriendusedtp", Player.SteamID)
                if time is None or (systick - time) < 0 or math.isnan(systick - time):
                    time = DataStore.Add("tpfriendcooldown", Player.SteamID, systick)

                calc = systick - time

 

[DreTaX]

It's a release.

http://fougerite.com/resources/tpfriend.60/

 

[Mr.Moody]

I was wondering how I could make the plugin so that if Player.Admin, /tpaccept is no longer required. I really want to learn more about making plugins so that when I understand it all I can contribute to Pluton.

 

[DreTaX]

Check my github and look for admincmds.

Sent from my Samsung Galaxy S4