Solved C# Plugin - Random Crash with threading
- Thread starter tarynkelley
- Start date
Rust Legacy Unity version really sucks. I also cannot use a Disconnect function in a timer :/ It also crashes the server randomly.
I know.
I'm trying to come up with a stuff that has nothing to do with timers or threads
Coroutines maybe?
I'm having a look at http://answers.unity3d.com/questions/357033/unity3d-and-c-coroutines-vs-threading.html at the moment.
I'm having a look at http://answers.unity3d.com/questions/357033/unity3d-and-c-coroutines-vs-threading.html at the moment.
Getting this error:
[Console] System.NullReferenceException: Object reference not set to an instance of an object
at Fougerite.Loom.QueueOnMainThread (System.Action action, Single time) [0x00000] in <filename unknown>:0
at Fougerite.Loom.QueueOnMainThread (System.Action action) [0x00000] in <filename unknown>:0
at Fougerite.Player.Disconnect () [0x00000] in <filename unknown>:0
at WhiteListCountry.WhiteListCountry.GeoInit (Fougerite.Player pl) [0x00000] in <filename unknown>:0
Source Code:
Loom only works when the player is completely connected? Or why this error message?
[Console] System.NullReferenceException: Object reference not set to an instance of an object
at Fougerite.Loom.QueueOnMainThread (System.Action action, Single time) [0x00000] in <filename unknown>:0
at Fougerite.Loom.QueueOnMainThread (System.Action action) [0x00000] in <filename unknown>:0
at Fougerite.Player.Disconnect () [0x00000] in <filename unknown>:0
at WhiteListCountry.WhiteListCountry.GeoInit (Fougerite.Player pl) [0x00000] in <filename unknown>:0
Source Code:
C#:
namespace WhiteListCountry
{
using Fougerite;
using Fougerite.Events;
using System;
using System.Globalization;
using System.IO;
using System.Threading;
using System.Collections.Generic;
using UnityEngine;
using GeoIP;
public class WhiteListCountry : Module
{
public static IniParser ConfigINI;
//public static DataStore ds = DataStore.GetInstance();
public static Dictionary<string, string> PluginSettings = new Dictionary<string, string> { };
public void GeoInit(Player pl)
{
try
{
GeoIP geo = GeoIP.Instance;
if (geo.GetDataOfIP(pl.IP) == null)
{
if (PluginSettings["SAM"] == "true")
{
string msg = PluginSettings["JM"];
msg = msg.Replace("%PLAYER%", pl.Name);
msg = msg.Replace("%COUNTRY%", PluginSettings["UL"]);
Server.GetServer().Broadcast(msg);
}
return;
}
string countrycode = geo.GetDataOfIP(pl.IP).CountryShort;
string country = geo.GetDataOfIP(pl.IP).Country;
string whitelist = PluginSettings["WL"];
string wlp = PluginSettings["WLP"];
string steamid = pl.SteamID;
if (find(whitelist, countrycode, wlp, steamid) == false)
{
string playerdisconnectMSG = PluginSettings["PDM"];
if (PluginSettings["SDM"] == "true")
{
string msg = PluginSettings["DM"];
msg = msg.Replace("%PLAYER%", pl.Name);
msg = msg.Replace("%COUNTRY%", country);
Server.GetServer().Broadcast(msg);
}
pl.Message("[color #FF0000] ------------------------");
pl.Message("[color #FF0000] WARNING");
pl.Message("[color #FF0000] " + playerdisconnectMSG + " [" + countrycode + "]");
pl.Message("[color #FF0000] Disconnecting now");
pl.Message("[color #FF0000] ------------------------");
try
{
if (pl.IsOnline) { pl.Disconnect(); }
}
catch (Exception ex)
{
Server.GetServer().Broadcast(ex.ToString());
Logger.Log(ex.ToString());
}
/* System.Timers.Timer _timer2;
_timer2 = new System.Timers.Timer(20000);
_timer2.Elapsed += (_, __) => pldisc(pl);
_timer2.Start(); */
}
else
{
if (PluginSettings["SAM"] == "true")
{
string msg = PluginSettings["JM"];
msg = msg.Replace("%PLAYER%", pl.Name);
msg = msg.Replace("%COUNTRY%", country);
Server.GetServer().Broadcast(msg);
}
}
}
catch
{
string msg = PluginSettings["JM"];
msg = msg.Replace("%PLAYER%", pl.Name);
msg = msg.Replace("%COUNTRY%", PluginSettings["UL"]);
Server.GetServer().Broadcast(msg);
}
}
public void PlayerConnect(Player pl)
{
Thread t1 = new Thread(() => GeoInit(pl));
t1.Start();
}
public bool find(string whitelist, string CountryCode, string wlp, string steamid)
{
try
{
whitelist = whitelist.Replace(" ", "");
string[] wl = whitelist.Split(',');
wlp = wlp.Replace(" ", "");
string[] wlpl = wlp.Split(',');
// Whitelist search
foreach (string s in wl)
{
if (CountryCode == s)
{
return true;
}
else
{
continue;
}
}
// WhiteListedPlayers search
foreach (string s in wlpl)
{
if (steamid == s)
{
return true;
}
else
{
continue;
}
}
return false;
}
catch
{
return false;
}
}
public void Command(Fougerite.Player Player, string cmd, string[] args)
{
if ((cmd == "wlreload") && Player.Admin)
{
if (args.Length == 0)
{
PluginSettings.Clear();
ConfigINI = new IniParser(@"Save\WhiteListCountry\Config.ini");
PluginSettings.Add("SAM", ConfigINI.GetSetting("Settings", "ShowAcceptedMessage"));
PluginSettings.Add("SDM", ConfigINI.GetSetting("Settings", "ShowDeniedMessage"));
PluginSettings.Add("WL", ConfigINI.GetSetting("WhiteList", "WhiteListedCountries"));
PluginSettings.Add("WLP", ConfigINI.GetSetting("WhiteList", "WhiteListedPlayers"));
PluginSettings.Add("JM", ConfigINI.GetSetting("Messages", "JoinMessage"));
PluginSettings.Add("PDM", ConfigINI.GetSetting("Messages", "PlayerDisconnectMessage"));
PluginSettings.Add("DM", ConfigINI.GetSetting("Messages", "ServerDisconnectMessage"));
PluginSettings.Add("UL", ConfigINI.GetSetting("Messages", "UnknownLocation"));
Player.Message("WhiteListCountry settings reloaded");
}
}
}
public override void DeInitialize()
{
Hooks.OnCommand -= new Hooks.CommandHandlerDelegate(this.Command);
Hooks.OnPlayerConnected -= PlayerConnect;
}
public override void Initialize()
{
Hooks.OnCommand += new Hooks.CommandHandlerDelegate(this.Command);
Hooks.OnPlayerConnected += PlayerConnect;
if (!Directory.Exists(@"Save\WhiteListCountry"))
{
Directory.CreateDirectory(@"Save\WhiteListCountry");
}
if (!File.Exists(@"Save\WhiteListCountry\Config.ini"))
{
File.Create(@"Save\WhiteListCountry\Config.ini").Close();
ConfigINI = new IniParser(@"Save\WhiteListCountry\Config.ini");
ConfigINI.AddSetting("Settings", "ShowAcceptedMessage", "true");
ConfigINI.AddSetting("Settings", "ShowDeniedMessage", "true");
ConfigINI.AddSetting("WhiteList", "WhiteListedCountries", "DE, NL");
ConfigINI.AddSetting("WhiteList", "WhiteListedPlayers", "76561197970657636");
ConfigINI.AddSetting("Messages", "JoinMessage", "%PLAYER% has connected from: %COUNTRY%");
ConfigINI.AddSetting("Messages", "PlayerDisconnectMessage", "Your country is not on the servers whitelist!");
ConfigINI.AddSetting("Messages", "ServerDisconnectMessage", "%PLAYER% is trying to connect from: %COUNTRY%, but it's not whitelisted");
ConfigINI.AddSetting("Messages", "UnknownLocation", "A hidden location");
ConfigINI.Save();
}
ConfigINI = new IniParser(@"Save\WhiteListCountry\Config.ini");
PluginSettings.Clear();
PluginSettings.Add("SAM", ConfigINI.GetSetting("Settings", "ShowAcceptedMessage"));
PluginSettings.Add("SDM", ConfigINI.GetSetting("Settings", "ShowDeniedMessage"));
PluginSettings.Add("WL", ConfigINI.GetSetting("WhiteList", "WhiteListedCountries"));
PluginSettings.Add("WLP", ConfigINI.GetSetting("WhiteList", "WhiteListedPlayers"));
PluginSettings.Add("JM", ConfigINI.GetSetting("Messages", "JoinMessage"));
PluginSettings.Add("PDM", ConfigINI.GetSetting("Messages", "PlayerDisconnectMessage"));
PluginSettings.Add("DM", ConfigINI.GetSetting("Messages", "ServerDisconnectMessage"));
PluginSettings.Add("UL", ConfigINI.GetSetting("Messages", "UnknownLocation"));
}
public override string Author
{
get
{
return "Nordi";
}
}
public override string Description
{
get
{
return "WhiteListCountry";
}
}
public override string Name
{
get
{
return "WhiteListCountry";
}
}
public override System.Version Version
{
get
{
return new System.Version("1.0");
}
}
}
}Loom only works when the player is completely connected? Or why this error message?
I'm using inside a thread the pl.Disconnect() function since you mentioned in the wiki that Loom is automatically called at this method.
Basically like:
public void PlayerConnect(Player pl)
{
Thread t1 = new Thread(() => GeoInit(pl));
t1.Start();
}
public void GeoInit(Player pl)
{
some code ...
If player is not on whitelist [
if (pl.IsOnline) { pl.Disconnect(); }
]
}
Basically like:
public void PlayerConnect(Player pl)
{
Thread t1 = new Thread(() => GeoInit(pl));
t1.Start();
}
public void GeoInit(Player pl)
{
some code ...
If player is not on whitelist [
if (pl.IsOnline) { pl.Disconnect(); }
]
}
Ahh yes yes. So It just throws a nullexception? Weird. I will add try catch to the function tomorrow to see what is throwing the null exception.
public void Disconnect()
{
if (this.IsOnline)
{
//Logger.LogError("Same? " + Thread.CurrentThread.ManagedThreadId + " - " + Bootstrap.CurrentThread.ManagedThreadId);
if (Thread.CurrentThread.ManagedThreadId != Bootstrap.CurrentThread.ManagedThreadId)
{
//Logger.LogError("Nope, invoking");
Loom.QueueOnMainThread(() => {
Disconnect();
});
return;
}
Server.GetServer().RemovePlayer(uid);
this.ourPlayer.netUser.Kick(NetError.Facepunch_Kick_RCON, false);
}
}
Is see that the Disconnect function is passed to Loom without any reference / object? Is it because of that maybe?
Direct error from Fougerite (via catch)
[5/15/2016 3:08:55 AM] [Console] System.NullReferenceException: Object reference not set to an instance of an object
at Fougerite.Loom.QueueOnMainThread (System.Action action, Single time) [0x00000] in <filename unknown>:0
at Fougerite.Loom.QueueOnMainThread (System.Action action) [0x00000] in <filename unknown>:0
at Fougerite.Player.Disconnect () [0x00000] in <filename unknown>:0
{
if (this.IsOnline)
{
//Logger.LogError("Same? " + Thread.CurrentThread.ManagedThreadId + " - " + Bootstrap.CurrentThread.ManagedThreadId);
if (Thread.CurrentThread.ManagedThreadId != Bootstrap.CurrentThread.ManagedThreadId)
{
//Logger.LogError("Nope, invoking");
Loom.QueueOnMainThread(() => {
Disconnect();
});
return;
}
Server.GetServer().RemovePlayer(uid);
this.ourPlayer.netUser.Kick(NetError.Facepunch_Kick_RCON, false);
}
}
Is see that the Disconnect function is passed to Loom without any reference / object? Is it because of that maybe?
Direct error from Fougerite (via catch)
[5/15/2016 3:08:55 AM] [Console] System.NullReferenceException: Object reference not set to an instance of an object
at Fougerite.Loom.QueueOnMainThread (System.Action action, Single time) [0x00000] in <filename unknown>:0
at Fougerite.Loom.QueueOnMainThread (System.Action action) [0x00000] in <filename unknown>:0
at Fougerite.Player.Disconnect () [0x00000] in <filename unknown>:0
Last edited:
No.
The disconnect call is the instance. It's something different. I called this in EAC, and with any other stuff.
Hmm maybe its because I'm calling Player.Disconnect from a thread and not by System.Timers? Or is EAC also using threading? I will test the nightly build.
Before the release I tested It too with new Thread. It was in the release notes
Sent From My Samsung Galaxy S4
Sent From My Samsung Galaxy S4
[5/15/2016 3:18:01 PM] [Error] [Fougerite Loom Error] System.NullReferenceException: Object reference not set to an instance of an object
at Fougerite.Loom.QueueOnMainThread (System.Action action, Single time) [0x00000] in <filename unknown>:0
at Fougerite.Loom.QueueOnMainThread (System.Action action, Single time) [0x00000] in <filename unknown>:0
Yes a little more:
[5/15/2016 3:31:08 PM] [Error] Error for Taryn System.NullReferenceException: Object reference not set to an instance of an object
at Fougerite.Loom.QueueOnMainThread (System.Action action, Single time) [0x00000] in <filename unknown>:0
at Fougerite.Loom.QueueOnMainThread (System.Action action) [0x00000] in <filename unknown>:0
at Fougerite.Player.Disconnect () [0x00000] in <filename unknown>:0
[5/15/2016 3:31:08 PM] [Error] Error for Taryn (my Steam ID - removed it)
[5/15/2016 3:31:08 PM] [Error] Error for Taryn 2
[5/15/2016 3:31:08 PM] [Error] Error for Taryn 1
[5/15/2016 3:31:08 PM] [Error] Error for Taryn System.NullReferenceException: Object reference not set to an instance of an object
at Fougerite.Loom.QueueOnMainThread (System.Action action, Single time) [0x00000] in <filename unknown>:0
at Fougerite.Loom.QueueOnMainThread (System.Action action) [0x00000] in <filename unknown>:0
at Fougerite.Player.Disconnect () [0x00000] in <filename unknown>:0
[5/15/2016 3:31:08 PM] [Error] Error for Taryn (my Steam ID - removed it)
[5/15/2016 3:31:08 PM] [Error] Error for Taryn 2
[5/15/2016 3:31:08 PM] [Error] Error for Taryn 1