reason why it somthimes wont work?

ggblade

Member
Member
Aug 14, 2014
29
0
6
JavaScript:
function On_PlayerConnected(Player){
    if (getHackerID(Player.SteamID) == "Banned" || getHackerIP(Player.SteamIP) == "Banned" ) {
        Player.Message("You have been banned");
        Player.Disconnect();
    }
the ban command works, the players get added to the list, and there ip, but for some reason the bans just go uid and not ip, the person changes uid but stays same ip and can reconnect
 

Viproz

Moderator
Moderator
Aug 12, 2014
39
9
8
France
What is the function getHackerIP ?
If you coul paste getHackerID too to see the diffrences it would be cool :)
 

ggblade

Member
Member
Aug 14, 2014
29
0
6
trying out the player.steamip,
might take a while before i can say its fixed.

otherwise, more giving more info incase it woundt fix it...
JavaScript:
function On_Command(Player, cmd, args){
    if(cmd=="banip" && (Player.Admin || Player.SteamID == "01234567891011123" || Player.SteamID == "01234567891011123" || Player.SteamID == "01234567891011123" || Player.SteamID == "01234567891011123" || Player.SteamID == "01234567891011123" || Player.SteamID == "01234567891011123")) {
    var target = Player.Find(args[0]);
            if(target.Name == undefined){
                Player.Message("Player not found: " + args[0]);
                }
                else {
                Player.Message("you banned " + target.Name);
                target.Inventory.ClearAll();
                var ini = getHackerIni();
                ini.AddSetting("hackersID",target.SteamID,"Banned");
                ini.AddSetting("hackersIP",target.IP,"Banned");
                ini.AddSetting("hackersLog",target.SteamID,target.Name + " IP:" + target.IP + " banned by " +Player.Name);
                ini.Save();
                target.Kill();
                target.Disconnect();
            }
        }
    }
function On_PlayerConnected(Player){
    if (getHackerID(Player.SteamID) == "Banned || getHackerIP(Player.IP) == "Banned") {
        Player.Message("You have been banned");
        Player.Disconnect();
    }
}

function getHackerID(hacker) {
    var ini = getHackerIni();
    var hackerINI = ini.GetSetting("hackersID", hacker);
    return hackerINI;
}

function getHackerIP(hacker) {
    var ini = getHackerIni();
    var hackerINI = ini.GetSetting("hackersIP", hacker);
    return hackerINI;
}
function getHackerIni() {
    if(!Plugin.IniExists("hackers"))
        Plugin.CreateIni("hackers");
    return Plugin.GetIni("hackers");
if (getHackerID(Player.SteamID) == "Banned || getHackerIP(Player.SteamIP) == "Banned")
already changed into
if (getHackerID(Player.SteamID) == "Banned || getHackerIP(Player.IP) == "Banned")

in the above code
 

DreTaX

Probably knows the answer...
Administrator
Jun 29, 2014
4,093
4,784
113
At your house.
github.com
trying out the player.steamip,
might take a while before i can say its fixed.

otherwise, more giving more info incase it woundt fix it...
JavaScript:
function On_Command(Player, cmd, args){
    if(cmd=="banip" && (Player.Admin || Player.SteamID == "01234567891011123" || Player.SteamID == "01234567891011123" || Player.SteamID == "01234567891011123" || Player.SteamID == "01234567891011123" || Player.SteamID == "01234567891011123" || Player.SteamID == "01234567891011123")) {
    var target = Player.Find(args[0]);
            if(target.Name == undefined){
                Player.Message("Player not found: " + args[0]);
                }
                else {
                Player.Message("you banned " + target.Name);
                target.Inventory.ClearAll();
                var ini = getHackerIni();
                ini.AddSetting("hackersID",target.SteamID,"Banned");
                ini.AddSetting("hackersIP",target.IP,"Banned");
                ini.AddSetting("hackersLog",target.SteamID,target.Name + " IP:" + target.IP + " banned by " +Player.Name);
                ini.Save();
                target.Kill();
                target.Disconnect();
            }
        }
    }
function On_PlayerConnected(Player){
    if (getHackerID(Player.SteamID) == "Banned || getHackerIP(Player.IP) == "Banned") {
        Player.Message("You have been banned");
        Player.Disconnect();
    }
}

function getHackerID(hacker) {
    var ini = getHackerIni();
    var hackerINI = ini.GetSetting("hackersID", hacker);
    return hackerINI;
}

function getHackerIP(hacker) {
    var ini = getHackerIni();
    var hackerINI = ini.GetSetting("hackersIP", hacker);
    return hackerINI;
}
function getHackerIni() {
    if(!Plugin.IniExists("hackers"))
        Plugin.CreateIni("hackers");
    return Plugin.GetIni("hackers");
if (getHackerID(Player.SteamID) == "Banned || getHackerIP(Player.SteamIP) == "Banned")
already changed into
if (getHackerID(Player.SteamID) == "Banned || getHackerIP(Player.IP) == "Banned")

in the above code
You are missing a " from the code. Also, you might wanna look into my BannedPeople plugin.
 

Jakkee

Retired Staff
Retired Staff
Plugin Developer
Jul 28, 2014
1,465
932
113
Australia
@ggblade
You're last function should be:
JavaScript:
function getHackerIni() {
    if(!Plugin.IniExists("hackers"))
        Plugin.CreateIni("hackers");
    }
    return Plugin.GetIni("hackers");
}